Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anonymous user #3965

Merged
merged 21 commits into from
Oct 1, 2024
Merged

Anonymous user #3965

merged 21 commits into from
Oct 1, 2024

Conversation

bastianjoel
Copy link
Member

@bastianjoel bastianjoel commented Aug 1, 2024 •
edited
Loading

part of #3955

this PR assumes that active_meeting_ids in organization gets restriction mode A. (changed)

Needs:
https://github.com/OpenSlides/openslides-media-service/tree/feature/anonymous-user

@bastianjoel bastianjoel mentioned this pull request Aug 13, 2024
Merged
@MSoeb MSoeb self-requested a review August 19, 2024 07:35
MSoeb
MSoeb requested changes Aug 19, 2024
View reviewed changes
Copy link

@MSoeb MSoeb left a comment •
edited by bastianjoel
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Login page: Rewording of new button to 'Public access'
  • User account name for Anonymous user: Rename it to 'Public'
  • Group permission matrix > Group default name for anonymous user: rename it to 'Public'
  • Group permission matrix > Positioning: The group should always be listed as the first group on the left after activation.

Settings > General:

  • Add a new heading 'System' above 'Closed Meeting'. The formatting should be the same as for 'Meeting information'

  • Place new setting below 'closed meeting'

  • Add a gray placeholder help text under new setting (Hint: will be changed during translations)

  • Global search: Didn't work currently. It should be possible to use Global search as public user. The accessible content is limited and defined by all public available data.

  • Dashboard > calender: Üublic user could see committee icon. -> Should not be visible

  • Chat / commentary field for motions: Public user group can't be selected. -> It should be possible to set the public group as 'Group with reading permission'. / In comparison: Writing should not be possible. (needs discussion)

@MSoeb MSoeb mentioned this pull request Aug 22, 2024
Closed
@bastianjoel
Copy link
Member Author

bastianjoel commented Aug 27, 2024 •
edited
Loading

Group permission matrix > Group default name for anonymous user: rename it to 'Public'

Needs to be done in backend

Group permission matrix > Positioning: The group should always be listed as the first group on the left after activation.

I would prefer a backend solution here too

Global search

Works for me might be a problem with your setup

@bastianjoel
Copy link
Member Author

bastianjoel commented Aug 27, 2024 •
edited
Loading

Add a gray placeholder help text under new setting (Hint: will be changed during translations)

Why not just add it when translating?

@bastianjoel bastianjoel requested a review from MSoeb August 27, 2024 13:57
@bastianjoel bastianjoel assigned MSoeb and unassigned bastianjoel Aug 27, 2024
@rrenkert
Copy link
Member

Global search

Works for me might be a problem with your setup

Correct. Our stating setup does not have a running search service. I will talk to @m-schieder .

MSoeb
MSoeb requested changes Aug 29, 2024
View reviewed changes
Copy link

@MSoeb MSoeb left a comment •
edited by bastianjoel
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it with @emanuelschuetze. We've found the following issues:

  • User profil: language change doesn't work instantly. reload is needed
  • Group name: Should be changed from 'Anonymous' to 'Public'. [Backend]
  • Group position after activation: 'Public' group should be first in the group listing. [Backend]
  • Dashboard > calender > meeting card: old committee icon position is not clickable -> whole card shoould be clickable
  • Chat / commentary field for motions: Public user group can't be selected. -> It should be possible to set the public group as 'Group with reading permission'. - No writing permission. It should be a one-way-communication. / @rrenkert I have in mind we talked about it, but I can't remember if there were any hurdles to implement it. If yes, could you please write them for down?
  • User name: Should be changed to 'Public'.

@bastianjoel
Copy link
Member Author

There are some problems with the dashboard being displayed after reload even with just one meeting public.

@MSoeb MSoeb assigned emanuelschuetze and unassigned MSoeb Aug 30, 2024
@bastianjoel bastianjoel mentioned this pull request Sep 12, 2024
Merged
@bastianjoel
Copy link
Member Author

Global search: didn't work currently -> global search in available content should be possible -> didn't work. I get error messages in console by searching something. (TypeError: Cannot read properties of null (reading 'message'))

Still a setup issue. You don't need to document this here.

@bastianjoel
Copy link
Member Author

Add a new filter 'Status' in meeting list. The options should be 'is archived', 'is not archived', 'closed' and 'public'. -> The new filter that summarizes the different statuses of meetings is still missing. The 'Archived' filter is then obsolete as these options are integrated in the new 'Status' filter and can be deleted.

A second filter will be used. Option is closed needs to be renamed to is not public

@bastianjoel bastianjoel assigned MSoeb and unassigned bastianjoel Sep 27, 2024
@MSoeb
Copy link

MSoeb commented Sep 30, 2024

Have tested now the global search. Changes needed:

  • The gray description path in a search result has html code in it. -> description should be clean without the code.
    image

  • I could search for users like Administrator and I get a result which refers to the account menu. Also the option to search in participants is available. This should not happen. The public access is only for content, not accounts or users. .
    --> solution: Participant filter should not be available. Searching for users should not list results associated to the account menu or any participant menu.

@MSoeb MSoeb assigned bastianjoel and unassigned MSoeb Sep 30, 2024
MSoeb
MSoeb previously requested changes Sep 30, 2024
View reviewed changes
Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment

@bastianjoel
Copy link
Member Author

bastianjoel commented Sep 30, 2024 •
edited by Elblinator
Loading

The gray description path in a search result has html code in it. -> description should be clean without the code.

I suspect this also happens for normal users. Please open an separate issue.

#4197

@bastianjoel
Copy link
Member Author

Participant filter should not be available. Searching for users should not list results associated to the account menu or any participant menu.

This is also not related to this PR. Please contact me if you want further explanation.

@bastianjoel bastianjoel assigned MSoeb and unassigned bastianjoel Sep 30, 2024
@rrenkert
Copy link
Member

Participant filter should not be available. Searching for users should not list results associated to the account menu or any participant menu.

This is also not related to this PR. Please contact me if you want further explanation.

@bastianjoel Can you please create a new issue for this to address the problem correctly?

@Elblinator
Copy link
Member

#4197

@Elblinator Elblinator mentioned this pull request Sep 30, 2024
Closed
@luisa-beerboom luisa-beerboom dismissed MSoeb’s stale review October 1, 2024 11:59

Feature review resolved through @emanuelschuetze's review

@luisa-beerboom luisa-beerboom merged commit ed86828 into OpenSlides:feature/anonymous-user Oct 1, 2024
5 checks passed
@bastianjoel bastianjoel deleted the 3955-anon branch October 1, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisa-beerboom luisa-beerboom luisa-beerboom approved these changes

@emanuelschuetze emanuelschuetze emanuelschuetze approved these changes

@MSoeb MSoeb Awaiting requested review from MSoeb

Assignees

@luisa-beerboom luisa-beerboom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bastianjoel @rrenkert @MSoeb @Elblinator @emanuelschuetze @luisa-beerboom